Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove potential race condition in https renegotiation test #25601

Closed
wants to merge 1 commit into from
Closed

test: remove potential race condition in https renegotiation test #25601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions test/pummel/test-https-ci-reneg-attack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,12 @@ function test(next) {
key: fixtures.readSync('test_key.pem')
};

let seenError = false;

const server = https.createServer(options, function(req, res) {
const conn = req.connection;
conn.on('error', function(err) {
console.error(`Caught exception: ${err}`);
assert(/TLS session renegotiation attack/.test(err));
conn.destroy();
seenError = true;
});
res.end('ok');
});
Expand All @@ -77,7 +74,6 @@ function test(next) {
let renegs = 0;

child.stderr.on('data', function(data) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using .on('data') without any sort of buffering might also be very brittle and something that we should fix…?

if (seenError) return;
handshakes += ((String(data)).match(/verify return:1/g) || []).length;
if (handshakes === 2) spam();
renegs += ((String(data)).match(/RENEGOTIATING/g) || []).length;
Expand Down