Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: run html/webappapis/timers WPT #25618

Closed
wants to merge 2 commits into from
Closed

test: run html/webappapis/timers WPT #25618

wants to merge 2 commits into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jan 21, 2019 •
edited
Loading

test: pull html/webappapis/timers WPT

Using

git node wpt html/webappapis/timers

test: run html/webappapis/timers WPT

Note that currently only missing-timeout-setinterval.any.js gets run - other tests are not yet ported to .js in the upstream.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2324/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 21, 2019
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20240/

@joyeecheung
Copy link
Member Author

Rebased. CI: https://ci.nodejs.org/job/node-test-pull-request/20300/

@joyeecheung
Copy link
Member Author

Ping @nodejs/testing

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2019
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20461/

@joyeecheung
Copy link
Member Author

CI was green, though node-test-commit got interrupted so the final status was red

@joyeecheung
Copy link
Member Author

Landed in 4b6e4c1...d9066be

joyeecheung added a commit that referenced this pull request Jan 31, 2019
@joyeecheung
test: pull html/webappapis/timers WPT
476531b 
Using

```
git node wpt html/webappapis/timers
```

PR-URL: #25618
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Jan 31, 2019
@joyeecheung
test: run html/webappapis/timers WPT
d9066be 
PR-URL: #25618
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 1, 2019
@joyeecheung @addaleax
test: pull html/webappapis/timers WPT
5792208 
Using

```
git node wpt html/webappapis/timers
```

PR-URL: #25618
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 1, 2019
@joyeecheung @addaleax
test: run html/webappapis/timers WPT
5bffcf6 
PR-URL: #25618
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyeecheung @nodejs-github-bot @jasnell