Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] test: fail on broken coverage #25623

Closed
wants to merge 1 commit into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jan 21, 2019

@mhdawson let's make a smoke testing build that runs make coverage-run-js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@bcoe bcoe requested a review from mhdawson January 21, 2019 20:45
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 21, 2019
@antsmartian antsmartian added the wip Issues and PRs that are still a work in progress. label Jan 22, 2019
@thefourtheye
Copy link
Contributor

@bcoe Are we building a whitelist of tests which fail with the coverage instrumentation?

@bcoe
Copy link
Contributor Author

bcoe commented Jan 22, 2019

@thefourtheye this is the intention. @mhdawson is helping with this, and we're using this branch to test.

Also, have this pull request open bcoe/c8#59, adding the ability to make our reporting fail if a threshold isn't met -- the idea is that we can ensure coverage is running, and hasn't dropped below a conservative lower bound.

@bcoe bcoe closed this Jan 24, 2019
@bcoe bcoe deleted the fail-on-coverage-failure branch January 24, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. wip Issues and PRs that are still a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants