test: remove known_issues/test-cluster-bind-privileged-port #25649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was added to check for a bug in macOS Mojave, but it turns out the issue is a macOS feature, not a bug. Refs: nodejs#21679 (comment) Fixes: nodejs#21679
cjihrig
approved these changes
Jan 22, 2019
Trott
added
the
author ready
devsnek
approved these changes
Jan 23, 2019
|
Landed in 35f45ba |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 24, 2019
The test was added to check for a bug in macOS Mojave, but it turns out the issue is a macOS feature, not a bug. Refs: nodejs#21679 (comment) Fixes: nodejs#21679 PR-URL: nodejs#25649 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
addaleax
pushed a commit
that referenced
this pull request
Jan 28, 2019
The test was added to check for a bug in macOS Mojave, but it turns out the issue is a macOS feature, not a bug. Refs: #21679 (comment) Fixes: #21679 PR-URL: #25649 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 29, 2019
The test was added to check for a bug in macOS Mojave, but it turns out the issue is a macOS feature, not a bug. Refs: #21679 (comment) Fixes: #21679 PR-URL: #25649 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
The test was added to check for a bug in macOS Mojave, but it turns out the issue is a macOS feature, not a bug. Refs: #21679 (comment) Fixes: #21679 PR-URL: #25649 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
The test was added to check for a bug in macOS Mojave, but it turns out the issue is a macOS feature, not a bug. Refs: #21679 (comment) Fixes: #21679 PR-URL: #25649 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was added to check for a bug in macOS Mojave, but it turns out
the issue is a macOS feature, not a bug.
Refs: #21679 (comment)
Fixes: #21679
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes