Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: refactor ERR_SYNTHETIC #25749

Merged
merged 1 commit into from
Jan 30, 2019
Merged

lib: refactor ERR_SYNTHETIC #25749

merged 1 commit into from
Jan 30, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 28, 2019

  • Tidy up description in docs.
  • Remove a second definition in the docs.
  • Remove unused string input parameter.
  • Remove duplicate "JavaScript Callstack" in error messages.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2411/pipeline

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. process Issues and PRs related to the process subsystem. labels Jan 28, 2019
Trott
Trott reviewed Jan 28, 2019
View reviewed changes
doc/api/errors.md Outdated Show resolved Hide resolved
@greeneterran

This comment has been minimized.

Sign in to view
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 30, 2019

Green CI: https://ci.nodejs.org/job/node-test-commit/25453/

@cjihrig
lib: refactor ERR_SYNTHETIC
5aa89d6 
- Tidy up description in docs.
- Remove a second definition in the docs.
- Remove unused string input parameter.
- Remove duplicate "JavaScript Callstack" in error messages.

PR-URL: nodejs#25749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig cjihrig merged commit 5aa89d6 into nodejs:master Jan 30, 2019
@cjihrig cjihrig deleted the synthetic branch January 30, 2019 20:55
addaleax pushed a commit that referenced this pull request Jan 30, 2019
@cjihrig @addaleax
lib: refactor ERR_SYNTHETIC
99bc0df 
- Tidy up description in docs.
- Remove a second definition in the docs.
- Remove unused string input parameter.
- Remove duplicate "JavaScript Callstack" in error messages.

PR-URL: #25749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@antsmartian antsmartian antsmartian approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjihrig @nodejs-github-bot @greeneterran @jasnell @Trott @addaleax @antsmartian @lpinca @richardlau @gireeshpunathil