Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: make test.py Python 3 compatible #25767

Closed
wants to merge 3 commits into from
Closed

tools: make test.py Python 3 compatible #25767

wants to merge 3 commits into from

Conversation

thefourtheye
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

cc @nodejs/python @cclauss @gengjiawen

@thefourtheye thefourtheye added tools Issues and PRs related to the tools directory. python PRs and issues that require attention from people who are familiar with Python. labels Jan 28, 2019
@nodejs-github-bot
Copy link
Collaborator

@thefourtheye build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2419/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 28, 2019
@thefourtheye thefourtheye mentioned this pull request Jan 28, 2019
Closed
4 tasks
gengjiawen
gengjiawen approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job.

cclauss
cclauss reviewed Jan 28, 2019
View reviewed changes
tools/test.py Show resolved Hide resolved
cclauss
cclauss approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

cclauss
cclauss reviewed Jan 28, 2019
View reviewed changes
tools/test.py Outdated Show resolved Hide resolved
mhdawson
mhdawson approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss cclauss mentioned this pull request Jan 29, 2019
Closed
63 tasks
@danbev
Copy link
Contributor

danbev commented Feb 1, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20507/

@addaleax
Copy link
Member

addaleax commented Feb 1, 2019

Landed in 5e0a326

(Side note: It’s a shame that git node land doesn’t automatically pick up non-collaborator approvals :/)

@addaleax addaleax closed this Feb 1, 2019
addaleax pushed a commit that referenced this pull request Feb 1, 2019
@thefourtheye @addaleax
tools: make test.py Python 3 compatible
5e0a326 
PR-URL: #25767
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: cclauss <cclauss@me.com>
Reviewed-By: gengjiawen <technicalcute@gmail.com>
@richardlau
Copy link
Member

(Side note: It’s a shame that git node land doesn’t automatically pick up non-collaborator approvals :/)

Isn't that by design?

@thefourtheye thefourtheye deleted the make-test.py-python3-compatible branch February 2, 2019 07:08
addaleax pushed a commit that referenced this pull request Feb 3, 2019
@thefourtheye @addaleax
tools: make test.py Python 3 compatible
9f1bcd4 
PR-URL: #25767
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: cclauss <cclauss@me.com>
Reviewed-By: gengjiawen <technicalcute@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@addaleax addaleax addaleax approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@thefourtheye @nodejs-github-bot @danbev @addaleax @richardlau @cclauss @gengjiawen @mhdawson