-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: bump cpplint.py to 3d8f6f876d #25771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber Stamp LGTM
@@ -1289,8 +1297,8 @@ def RepositoryName(self): | |||
""" | |||
fullname = self.FullName() | |||
# XXX(bnoordhuis) Expects that cpplint.py lives in the tools/ directory. | |||
toplevel = os.path.abspath(os.path.join(os.path.dirname(__file__), '..')) \ | |||
.replace('\\', '/').decode('utf-8') | |||
toplevel = os.path.abspath(os.path.join(os.path.dirname(__file__), '..')).replace('\\', '/') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long line.
@@ -4677,7 +4677,7 @@ def _ClassifyInclude(fileinfo, include, is_system): | |||
|
|||
# Headers with C++ extensions shouldn't be considered C system headers | |||
if is_system and os.path.splitext(include)[1] in ['.hpp', '.hxx', '.h++']: | |||
is_system = False | |||
is_system = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent error (or does this come from upstream?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google favors is 2 space indentation. There is a pretty good chance that this code was formatted with https://github.com/google/yapf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All white-space changes are lifted verbatim from https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
P.S. I'll refactor the commits to make that easier to review
ee8cbf3
to
6404279
Compare
PR-URL: nodejs#25771 Fixes: nodejs#25760 Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* Preserve 3 node-core checks * Preserve patch to `FileInfo.RepositoryName` * Remove TAP to logfile (unused) PR-URL: nodejs#25771 Fixes: nodejs#25760 Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
6404279
to
4d19300
Compare
PR-URL: #25771 Fixes: #25760 Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* Preserve 3 node-core checks * Preserve patch to `FileInfo.RepositoryName` * Remove TAP to logfile (unused) PR-URL: #25771 Fixes: #25760 Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fixes: #25760
Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
/CC @nodejs/build-files @nodejs/python
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes