Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise style guide #25778

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 28, 2019

Use italics for words-as-words within style guide. Other minor
improvements.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Use italics for words-as-words within style guide. Other minor
improvements.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 28, 2019
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2019
@Trott
Copy link
Member Author

Trott commented Jan 31, 2019

Landed in d34671a

@Trott Trott closed this Jan 31, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jan 31, 2019
Use italics for words-as-words within style guide. Other minor
improvements.

PR-URL: nodejs#25778
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 1, 2019
Use italics for words-as-words within style guide. Other minor
improvements.

PR-URL: #25778
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
@Trott Trott deleted the revise-style-guide branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants