Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused method in js_stream.h #25790

Closed
wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

not used anymore after this patch: 7c4b09b.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 29, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@danbev
Copy link
Contributor

danbev commented Feb 1, 2019

@addaleax
Copy link
Member

addaleax commented Feb 1, 2019

Landed in 8c8144e 🎉

@addaleax addaleax closed this Feb 1, 2019
addaleax pushed a commit that referenced this pull request Feb 1, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25790
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Feb 3, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25790
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants