Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add hasCrypto to worker-cleanexit-with-moduleload #25811

Closed
wants to merge 3 commits into from
Closed

test: add hasCrypto to worker-cleanexit-with-moduleload #25811

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d02a66e
test: add hasCrypto to worker-cleanexit-with-moduleload
danbev Jan 30, 2019
2f5fac1
squash!: conditionally add https to list of modules
danbev Jan 31, 2019
722bf77
squash!: fix linter issues
danbev Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions test/parallel/test-worker-cleanexit-with-moduleload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
require('../common');
const common = require('../common');

// Harden the thread interactions on the exit path.
// Ensure workers are able to bail out safe at
Expand All @@ -9,10 +9,15 @@ require('../common');
// preferrably in the C++ land.

const { Worker } = require('worker_threads');
const modules = [ 'fs', 'assert', 'async_hooks', 'buffer', 'child_process',
'net', 'http', 'os', 'path', 'v8', 'vm'
];
if (common.hasCrypto) {
modules.push('https');
}

for (let i = 0; i < 10; i++) {
new Worker("const modules = ['fs', 'assert', 'async_hooks'," +
"'buffer', 'child_process', 'net', 'http', 'https', 'os'," +
"'path', 'v8', 'vm'];" +
new Worker(`const modules = [${modules.map((m) => `'${m}'`)}];` +
'modules.forEach((module) => {' +
'const m = require(module);' +
'});', { eval: true });
Expand Down