Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: exclude additional test for coverage #25833

Closed
wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

Exclude async-hooks/test-callback-error as it seems
to fail consistently when run with coverage on
the docker ubuntu16 machines we plan to run the
coverage sanity test on.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Exclude async-hooks/test-callback-error as it seems
to fail consistently when run with coverage on
the docker ubuntu16 machines we plan to run the
coverage sanity test on.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 30, 2019
@mhdawson
Copy link
Member Author

@fyi #bcoe

test/root.status Outdated
@@ -163,3 +163,4 @@ sequential/test-util-debug: SLOW
[$type==coverage]
js-native-api/test_function/test: PASS,FAIL,CRASH
js-native-api/test_general/testFinalizer: PASS,FAIL,CRASH
async-hooks/test-callback-error: PASS,FAIL,CRASH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest sorting this (i.e. put this above the js-native-api tests).

@mhdawson
Copy link
Member Author

@mhdawson
Copy link
Member Author

Resume build due arm failures: https://ci.nodejs.org/job/node-test-pull-request/20495/

@mhdawson
Copy link
Member Author

mhdawson commented Feb 1, 2019

Ok CI run good, will land once 48hours is up.

@mhdawson
Copy link
Member Author

mhdawson commented Feb 1, 2019

Landed as c369b3e

@mhdawson mhdawson closed this Feb 1, 2019
mhdawson added a commit that referenced this pull request Feb 1, 2019
Exclude async-hooks/test-callback-error as it seems
to fail consistently when run with coverage on
the docker ubuntu16 machines we plan to run the
coverage sanity test on.

PR-URL: #25833
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 1, 2019
Exclude async-hooks/test-callback-error as it seems
to fail consistently when run with coverage on
the docker ubuntu16 machines we plan to run the
coverage sanity test on.

PR-URL: #25833
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
@mhdawson mhdawson deleted the cov-fail-test branch September 30, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants