Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x] src: pass along errors from PromiseWrap instantiation #25837

Closed
wants to merge 1 commit into from
Closed

[v11.x] src: pass along errors from PromiseWrap instantiation #25837

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jan 30, 2019 •
edited
Loading

Backport of one commit from #25734, with a minor conflict due to #23443 resolved.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: pass along errors from PromiseWrap instantiation
a29a712 
PR-URL: nodejs#25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2462/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v11.x labels Jan 30, 2019
@addaleax addaleax force-pushed the backport-promise-wrap-newinstance branch from 8cfe09a to a29a712 Compare January 30, 2019 23:35
@addaleax
Copy link
Member Author

addaleax commented Feb 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20554/

@addaleax
Copy link
Member Author

addaleax commented Feb 3, 2019

Landed in 882902c

addaleax added a commit that referenced this pull request Feb 3, 2019
@addaleax
src: pass along errors from PromiseWrap instantiation
882902c 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

PR-URL: #25837
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@addaleax addaleax closed this Feb 3, 2019
@addaleax addaleax deleted the backport-promise-wrap-newinstance branch February 3, 2019 19:49
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addaleax @nodejs-github-bot @targos