-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update acorn to 6.0.6 #25844
deps: update acorn to 6.0.6 #25844
Conversation
/cc @nodejs/repl |
@@ -29,7 +29,7 @@ fi | |||
|
|||
|
|||
# Dependencies bundled in distributions | |||
addlicense "Acorn" "deps/acorn" "$(cat ${rootdir}/deps/acorn/LICENSE)" | |||
addlicense "Acorn" "deps/acorn" "$(cat ${rootdir}/deps/acorn/acorn/LICENSE)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add acorn-walk
separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure.
acorn is a monorepo: https://github.com/acornjs/acorn
The license files are exactly the same, and I changed the license-builder to read one of them but it still says deps/acorn
, which includes both packages.
👀 Acorn bumped to 6.0.7. |
acorn and acorn-walk are now published as two different packages. Put them both in subdirectories of `deps/acorn`. Adapt the REPL's recoverable error detection to use the new API for extending acorn parsers.
Updated to 6.0.7 |
Re-run of failing node-test-commit-arm |
Re-run again: https://ci.nodejs.org/job/node-test-commit-arm/22031/ |
acorn and acorn-walk are now published as two different packages. Put them both in subdirectories of `deps/acorn`. Adapt the REPL's recoverable error detection to use the new API for extending acorn parsers. PR-URL: nodejs#25844 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Landed in 582c122 |
acorn and acorn-walk are now published as two different packages. Put them both in subdirectories of `deps/acorn`. Adapt the REPL's recoverable error detection to use the new API for extending acorn parsers. PR-URL: #25844 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
acorn and acorn-walk are now published as two different packages. Put
them both in subdirectories of
deps/acorn
.Adapt the REPL's recoverable error detection to use the new API for
extending acorn parsers.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes