Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update acorn to 6.0.6 #25844

Closed
wants to merge 1 commit into from
Closed

deps: update acorn to 6.0.6 #25844

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jan 31, 2019

acorn and acorn-walk are now published as two different packages. Put
them both in subdirectories of deps/acorn.
Adapt the REPL's recoverable error detection to use the new API for
extending acorn parsers.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 31, 2019
@targos targos added the repl Issues and PRs related to the REPL subsystem. label Jan 31, 2019
@targos
Copy link
Member Author

targos commented Jan 31, 2019

/cc @nodejs/repl

@@ -29,7 +29,7 @@ fi


# Dependencies bundled in distributions
addlicense "Acorn" "deps/acorn" "$(cat ${rootdir}/deps/acorn/LICENSE)"
addlicense "Acorn" "deps/acorn" "$(cat ${rootdir}/deps/acorn/acorn/LICENSE)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add acorn-walk separately?

Copy link
Member Author

@targos targos Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure.
acorn is a monorepo: https://github.com/acornjs/acorn
The license files are exactly the same, and I changed the license-builder to read one of them but it still says deps/acorn, which includes both packages.

@jdalton
Copy link
Member

jdalton commented Feb 4, 2019

👀 Acorn bumped to 6.0.7.

acorn and acorn-walk are now published as two different packages. Put
them both in subdirectories of `deps/acorn`.
Adapt the REPL's recoverable error detection to use the new API for
extending acorn parsers.
@targos
Copy link
Member Author

targos commented Feb 6, 2019

Updated to 6.0.7

@targos
Copy link
Member Author

targos commented Feb 6, 2019

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 6, 2019
@danbev
Copy link
Contributor

danbev commented Feb 7, 2019

Re-run of failing node-test-commit-arm

@targos
Copy link
Member Author

targos commented Feb 8, 2019

targos added a commit to targos/node that referenced this pull request Feb 8, 2019
acorn and acorn-walk are now published as two different packages. Put
them both in subdirectories of `deps/acorn`.
Adapt the REPL's recoverable error detection to use the new API for
extending acorn parsers.

PR-URL: nodejs#25844
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos
Copy link
Member Author

targos commented Feb 8, 2019

Landed in 582c122

@targos targos closed this Feb 8, 2019
@targos targos deleted the acorn6 branch February 8, 2019 14:44
addaleax pushed a commit that referenced this pull request Feb 8, 2019
acorn and acorn-walk are now published as two different packages. Put
them both in subdirectories of `deps/acorn`.
Adapt the REPL's recoverable error detection to use the new API for
extending acorn parsers.

PR-URL: #25844
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants