Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: move signal event handling into bootstrap/node.js #25859

Closed
wants to merge 1 commit into from

Commits on Jan 31, 2019

  1. lib: move signal event handling into bootstrap/node.js

    Moves the `process.on()` and `promise.emit()` calls happened during
    bootstrap for signal events into `bootstrap/node.js` so it's easier
    to tell the side effects.
    
    Drive-by changes:
    
    - Moves the signal event re-arming to a point later during
      the bootstrap - as early as it were it's unlikely that there
      could be any existing signal events to re-arm for node-report.
    - Use a Map instead of an Object for signal wraps since it is used
      as a deletable dictionary anyway.
    joyeecheung committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    5388fd5 View commit details
    Browse the repository at this point in the history