test: test sync version of mkdir & rmdir

[thefourtheye]

This patch includes tests for sync versions of mkdir and rmdir.
Also, it moves the test to parallel.

CI Run: https://jenkins-iojs.nodesource.com/job/node-test-pull-request/197/

[Fishrock123]

cc @nodejs/build this moves another test to /parallel/

[silverwind]

LGTM code wise. Are sync tests in parallel fine?

[Trott]

Sync tests in parallel are fine. There's already a whole bunch:

test/parallel/test-child-process-spawnsync-env.js
test/parallel/test-child-process-spawnsync-input.js
test/parallel/test-child-process-spawnsync-timeout.js
test/parallel/test-child-process-spawnsync.js
test/parallel/test-fs-append-file-sync.js
test/parallel/test-fs-fsync.js
test/parallel/test-fs-read-file-sync-hostname.js
test/parallel/test-fs-read-file-sync.js
test/parallel/test-fs-readfilesync-pipe-large.js
test/parallel/test-fs-sync-fd-leak.js
test/parallel/test-fs-write-file-sync.js
test/parallel/test-fs-write-sync.js
test/parallel/test-stdin-pause-resume-sync.js
test/parallel/test-stream2-read-sync-stack.js
test/parallel/test-sync-io-option.js

[silverwind]

Excuse me for asking, but why exactly do we split tests into parallel and sequential then?

[rvagg]

Tests in parallel are run in actual parallel processes by the python runner when run with -J according to the number of CPUs on the machine. So, anything that doesn't create a machine-dependency should go in there; examples of problematic tests include ones that bind to specific ports or use specific on-disk resources, those should go in sequential so as to not create inter-test conflicts.

[rvagg]

sorry, to answer the actual question @silverwind, "sync" tests in the Node sense are perfectly find and good to go in the parallel directory, they will be run in parallel Node processes

[Trott]

Parallel tests are run in parallel by four (or whatever) separate node processes. This is handled by the Python wrapper. So synchronous stuff is not a problem. It only becomes a problem if it (for example) binds to a port on localhost. Then it might be binding to a port that another process is trying to bind to. So that needs to go in sequential. (Temp directory stuff is also not a problem because the Python wrapper creates separate tmp directories for the different note processes.)

@rvagg just answered this so now my answer is superfluous but I typed it up, so here you go. Maybe there's a detail in there that is helpful.

[thefourtheye]

New CI Run: https://ci.nodejs.org/job/node-test-pull-request/332/

[thefourtheye]

Bump!

[jbergstroem]

LGTM

[thefourtheye]

Thanks for the review people, landed in 571a517