tools: improve prerequisites for test-all-suites #25892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prerequisistes for test-all-suites were running some tests themselves. When one of those tests failed during a coverage run, it resulted in artificially low coverage. Fix the prerequisites to only build stuff, not test.
nodejs-github-bot
added
the
build
|
@nodejs/build-files |
|
I'd like to fast-track this so we can use it for nodejs/build#1676 and get that closed out. Please 👍here to fast-track. |
|
Testing a coverage job with this too: https://ci.nodejs.org/view/All/job/node-test-commit-linux-coverage-daily/28/ EDIT: Results seem reasonable: 06:30:40 Javascript coverage %: 95.47%
06:30:40 C++ coverage %: 90.3% |
refack
approved these changes
Feb 2, 2019
addaleax
approved these changes
Feb 2, 2019
|
Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/20545/ |
Trott
added
the
author ready
|
Something odd is up with the resume build. Only Windows left to pass, so here's Windows CI: |
|
Landed in 4deb23a |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 3, 2019
The prerequisistes for test-all-suites were running some tests themselves. When one of those tests failed during a coverage run, it resulted in artificially low coverage. Fix the prerequisites to only build stuff, not test. PR-URL: nodejs#25892 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Feb 3, 2019
The prerequisistes for test-all-suites were running some tests themselves. When one of those tests failed during a coverage run, it resulted in artificially low coverage. Fix the prerequisites to only build stuff, not test. PR-URL: #25892 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prerequisistes for test-all-suites were running some tests
themselves. When one of those tests failed during a coverage run, it
resulted in artificially low coverage. Fix the prerequisites to only
build stuff, not test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes