Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test: don't assume broadcast traffic is unfiltered" #259

Merged
merged 2 commits into from
Jan 8, 2015
Merged

Revert "test: don't assume broadcast traffic is unfiltered" #259

merged 2 commits into from
Jan 8, 2015

Commits on Jan 8, 2015

  1. Revert "test: don't assume broadcast traffic is unfiltered" 

    This reverts commit 52e600a.

Reverted for:

* making the test fail with ENETUNREACH on OS X 10.8, and

* making the test fail with EHOSTDOWN on OS X 10.9 and 10.10 when there
  is no network connectivity, and

* leaving behind orphan processes that make subsequent tests fail with
  EADDRINUSE errors

PR-URL: nodejs#259
Reviewed-By: Rod Vagg <rod@vagg.org>
    @bnoordhuis
    bnoordhuis committed Jan 8, 2015
    Configuration menu
    Copy the full SHA
    df3c4ca View commit details
    Browse the repository at this point in the history

  2. test: move broadcast/multicast test to internet/ 

    Move parallel/test-dgram-broadcast-multi-process to test/internet.

The test does not play nice with firewalls that restrict broadcast
or multicast traffic, nor can it be rewritten to use only loopback
traffic without running into platform-specific limitations, see also
commits 52e600a and 236533c (TODO: update second one before landing.)

PR-URL: nodejs#259
Reviewed-By: Rod Vagg <rod@vagg.org>
    @bnoordhuis
    bnoordhuis committed Jan 8, 2015
    Configuration menu
    Copy the full SHA
    7266b75 View commit details
    Browse the repository at this point in the history