-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: make deleted function public in agent.h #25909
Conversation
Signed-off-by: gengjiawen <technicalcute@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but can you explain why in the commit log? This is like your other PR, right?
@bnoordhuis not quite sure which part you mean.I check the commit log, looks like right to me. |
Re-run of failing node-test-commit-arm/ |
@danbev Do I need to rebase my code ? |
I don't thinks so, I've re-run the failing build once more and it now passes: |
Landed in 3a02d39. |
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25909 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25909 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
make -j4 test
(UNIX), orvcbuild test
(Windows) passes