Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: catch internal segfaults #25915

Closed
wants to merge 1 commit into from
Closed

report: catch internal segfaults #25915

wants to merge 1 commit into from

Commits on Feb 4, 2019

  1. report: catch internal segfaults 

    `--diagnostic-report-on-fatalerror` does not capture internal
segfaults at present, instead limited to only faults that are
detected by the Node / v8. libuv's signal handler deliveres
result asynchronously which does not help for SIGSEGV as:
i) the synchronous sequence restarts the failing code,
ii) due to i) the callback is never delivered to the consumer.

Install a SIGSEGV handler in Node and follow the sequence of
fatalerror handling, as of now at least under report.

Fixes: nodejs#25762
    @gireeshpunathil
    gireeshpunathil committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    cf1f528 View commit details
    Browse the repository at this point in the history