Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: remove redundant call to socket.setTimeout() #25928

Closed
wants to merge 1 commit into from
Closed

http: remove redundant call to socket.setTimeout() #25928

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Feb 4, 2019

Socket.prototype.setTimeout() clears the previous timer before setting
a new one.

Refs: #25748 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@lpinca
http: remove redundant call to socket.setTimeout()
bdd2da2 
`Socket.prototype.setTimeout()` clears the previous timer before setting
a new one.

Refs: nodejs#25748 (comment)
@nodejs-github-bot
Copy link
Collaborator

@lpinca build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2507/pipeline

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Feb 4, 2019
@lpinca
Copy link
Member Author

lpinca commented Feb 5, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20584/

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 5, 2019
@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

Landed in cc5de5a

@addaleax addaleax closed this Feb 6, 2019
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@lpinca @addaleax
http: remove redundant call to socket.setTimeout()
cc5de5a 
`Socket.prototype.setTimeout()` clears the previous timer before setting
a new one.

Refs: #25748 (comment)

PR-URL: #25928
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@lpinca @addaleax
http: remove redundant call to socket.setTimeout()
b7fb49e 
`Socket.prototype.setTimeout()` clears the previous timer before setting
a new one.

Refs: #25748 (comment)

PR-URL: #25928
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca lpinca deleted the remove/redundant-set-timeout branch February 7, 2019 06:36
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lpinca @nodejs-github-bot @addaleax @apapirovski @jasnell @cjihrig