Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make watchdog async callback a lambda #25945

Merged
merged 1 commit into from
Feb 8, 2019
Merged

src: make watchdog async callback a lambda #25945

merged 1 commit into from
Feb 8, 2019

Conversation

gireeshpunathil
Copy link
Member

Watchdog::Async features only once for the async callback, so make it a lambda.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@gireeshpunathil build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2518/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 5, 2019
@danbev
Copy link
Contributor

danbev commented Feb 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20610/

@gireeshpunathil
Copy link
Member Author

Resume Build CI: https://ci.nodejs.org/job/node-test-commit/25684/

@gireeshpunathil
Copy link
Member Author

Resume Build CI: https://ci.nodejs.org/job/node-test-commit/25714/

@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 8, 2019
@gireeshpunathil
src: make watchdog async callback a lambda
7182aca 
`Watchdog::Async` features only once for the
async callback, so make it a lambda.

PR-URL: nodejs#25945
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gireeshpunathil gireeshpunathil removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 8, 2019
@gireeshpunathil gireeshpunathil merged commit 7182aca into nodejs:master Feb 8, 2019
@gireeshpunathil
Copy link
Member Author

landed as 7182aca

addaleax pushed a commit that referenced this pull request Feb 8, 2019
@gireeshpunathil @addaleax
src: make watchdog async callback a lambda
55a313b 
`Watchdog::Async` features only once for the
async callback, so make it a lambda.

PR-URL: #25945
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gireeshpunathil @nodejs-github-bot @danbev @jasnell @addaleax @cjihrig