Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: make a small internal assert module for built-in use #25956

Closed
wants to merge 3 commits into from
Closed

assert: make a small internal assert module for built-in use #25956

wants to merge 3 commits into from

Commits on Feb 6, 2019

  1. assert: refactor internal assert.js 

    Move lib/internal/assert.js to lib/internal/assert/assertion_error.js.
This is in preparation for making lib/internal/assert.js a tiny module
for use in Node.js built-ins so that we can use `assert()` without
having to load the entire ~1200 line `assert` module.
    @Trott
    Trott committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    e966998 View commit details
    Browse the repository at this point in the history

  2. assert: create internal/assert micro-module 

    For use in built-in modules that could benefit from `assert()` without
having to load the entire module (unless an AssertionError actually
occurs): lib/internal/assert.js.
    @Trott
    Trott committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    0e9b3e7 View commit details
    Browse the repository at this point in the history

  3. lib: replace 'assert' with 'internal/assert' for many built-ins 

    Replace large 'assert' module with tiny 'internal/assert' module for
many built-in uses.
    @Trott
    Trott committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    0a28cdb View commit details
    Browse the repository at this point in the history