report: use uv_getnameinfo() for socket endpoints #25962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Feb 6, 2019
jasnell
approved these changes
Feb 6, 2019
richardlau
approved these changes
Feb 6, 2019
addaleax
added
author ready
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20645/ EDIT: CI was green. |
PR-URL: nodejs#25962 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 8, 2019
PR-URL: #25962 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
This was referenced Feb 15, 2019
richardlau
added a commit
to richardlau/nodereport
that referenced
this pull request
Feb 21, 2019
Ports fixes from core: nodejs/node#25962 nodejs/node#26140 Fixes: nodejs#120
richardlau
added a commit
to richardlau/nodereport
that referenced
this pull request
Mar 5, 2019
Ports fixes from core: nodejs/node#25962 nodejs/node#26140 PR-URL: nodejs#123 Fixes: nodejs#120 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
richardlau
added a commit
to nodejs/node-report
that referenced
this pull request
Mar 5, 2019
Ports fixes from core: nodejs/node#25962 nodejs/node#26140 PR-URL: #123 Fixes: #120 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes