Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x backport] tools: update ESLint to 5.13.0 and replace deprecated configuration #25965

Closed
wants to merge 3 commits into from
Closed

[v11.x backport] tools: update ESLint to 5.13.0 and replace deprecated configuration #25965

wants to merge 3 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 6, 2019

Backport of #25877

@Trott
tools: update dmn in update-estlint.sh
82b2c25 
Version 2.1.0 of dmn will get rid of .map and .ts files.
@Trott
tools: update ESLint to 5.13.0
8ff6ce0
@Trott
tools: replace deprecated ESLint configuration
dc761c4 
For `globals`, booleans are deprecated in favor strings
`'readable'`/`'writeable'`.
@nodejs-github-bot nodejs-github-bot added tools Issues and PRs related to the tools directory. v11.x labels Feb 6, 2019
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2529/pipeline

@Trott Trott mentioned this pull request Feb 6, 2019
Closed
2 tasks
@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20618/

@Trott
Copy link
Member Author

Trott commented Feb 6, 2019

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20626/

@gengjiawen
Copy link
Member

Okay, maybe not a good time. But any thought on #25908 (comment) ?

@addaleax
Copy link
Member

addaleax commented Feb 7, 2019

@gengjiawen Yeah, this PR is only about backporting commits from master … let’s keep that discussion in the issue you linked :)

@addaleax
Copy link
Member

addaleax commented Feb 7, 2019

Landed in e81c6c8...c55d662, thanks for the backport!

@addaleax addaleax closed this Feb 7, 2019
addaleax pushed a commit that referenced this pull request Feb 7, 2019
@Trott @addaleax
tools: update dmn in update-estlint.sh
8d14870 
Version 2.1.0 of dmn will get rid of .map and .ts files.

Backport-PR-URL: #25965
PR-URL: #25877
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
addaleax pushed a commit that referenced this pull request Feb 7, 2019
@Trott @addaleax
tools: update ESLint to 5.13.0
e13c185 
Backport-PR-URL: #25965
PR-URL: #25877
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
addaleax pushed a commit that referenced this pull request Feb 7, 2019
@Trott @addaleax
tools: replace deprecated ESLint configuration
c55d662 
For `globals`, booleans are deprecated in favor strings
`'readable'`/`'writeable'`.

Backport-PR-URL: #25965
PR-URL: #25877
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@Trott Trott deleted the backport-25877 branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @addaleax @gengjiawen