Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove extraneous report validation argument #25986

Merged
merged 1 commit into from
Feb 9, 2019
Merged

test: remove extraneous report validation argument #25986

merged 1 commit into from
Feb 9, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 7, 2019

The second argument passed to validate() and validateContent() is not used for anything.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2534/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 7, 2019
@addaleax addaleax added the report Issues and PRs related to process.report. label Feb 7, 2019
@richardlau
Copy link
Member

The second argument passed to validate() and validateContent() is not used for anything.

Just noting that validate() and validateContent() in test/common/report.js here in core at the moment are much simpler than their equivalents in the standalone module, which does use the second argument to validate the expected information is included in the report.

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2019

Green CI: https://ci.nodejs.org/job/node-test-pull-request/20688/

@cjihrig
test: remove extraneous report validation argument
00366e2 
The second argument passed to validate() and validateContent()
is not used for anything.

PR-URL: nodejs#25986
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig cjihrig merged commit 00366e2 into nodejs:master Feb 9, 2019
@cjihrig cjihrig deleted the test-arg branch February 9, 2019 17:11
targos pushed a commit that referenced this pull request Feb 10, 2019
@cjihrig @targos
test: remove extraneous report validation argument
d123f94 
The second argument passed to validate() and validateContent()
is not used for anything.

PR-URL: #25986
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
report Issues and PRs related to process.report. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @nodejs-github-bot @richardlau @addaleax @lpinca