Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add TTY + assert test #26024

Closed
wants to merge 1 commit into from
Closed

test: add TTY + assert test #26024

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 10, 2019

This test adds coverage for a ternary in assertion_error.js that checks
if stderr is a TTY.

The line in question is

node/lib/internal/assert/assertion_error.js

Line 108 in e154176

const maxLength = process.stderr.isTTY ? process.stderr.columns : 80;
.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@Trott Trott requested a review from BridgeAR February 10, 2019 05:00
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2558/pipeline

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Feb 10, 2019
@Trott Trott added the assert Issues and PRs related to the assert subsystem. label Feb 10, 2019
@Trott
Copy link
Member Author

Trott commented Feb 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20702/

@Trott
Copy link
Member Author

Trott commented Feb 10, 2019

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20713/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 10, 2019
@Trott
test: add assert test for position indicator
8d9d083 
This test adds coverage for a ternary in assertion_error.js that checks
if stderr is a TTY.
@Trott
Copy link
Member Author

Trott commented Feb 10, 2019

Improved/clarified the test. (@cjihrig Probably worth re-reviewing.)

CI:

@Trott
Copy link
Member Author

Trott commented Feb 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20718/

@cjihrig
Copy link
Contributor

cjihrig commented Feb 11, 2019

Still LGTM

@antsmartian
Copy link
Contributor

antsmartian commented Feb 11, 2019 •
edited by Trott
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20726/ ✅

@Trott
Copy link
Member Author

Trott commented Feb 12, 2019

Landed in 40a8a73

@Trott Trott closed this Feb 12, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 12, 2019
@Trott
test: add assert test for position indicator
40a8a73 
This test adds coverage for a ternary in assertion_error.js that checks
if stderr is a TTY.

PR-URL: nodejs#26024
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 13, 2019
@Trott @addaleax
test: add assert test for position indicator
61330b2 
This test adds coverage for a ternary in assertion_error.js that checks
if stderr is a TTY.

PR-URL: #26024
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the cover-tty-assert branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antsmartian antsmartian antsmartian approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @cjihrig @antsmartian