lib: merge 'undefined' into one 'break' branch #26039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to split this alone, but just merge it into the 'break' switch branch together.
ghost
mentioned this pull request
addaleax
approved these changes
Feb 10, 2019
richardlau
approved these changes
Feb 10, 2019
JungMinu
approved these changes
Feb 11, 2019
antsmartian
approved these changes
Feb 11, 2019
devsnek
approved these changes
Feb 11, 2019
lpinca
approved these changes
Feb 11, 2019
thefourtheye
approved these changes
Feb 11, 2019
cjihrig
approved these changes
Feb 11, 2019
jasnell
approved these changes
Feb 11, 2019
|
Thanks all, it's done and passed checks |
antsmartian
added
the
author ready
|
Landed in 1411f7c |
pull bot
pushed a commit
to shakir-abdo/node
that referenced
this pull request
Feb 13, 2019
We don't need to split this alone, but just merge it into the 'break' switch branch together. PR-URL: nodejs#26039 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ghost
deleted the
targos
pushed a commit
that referenced
this pull request
Feb 14, 2019
We don't need to split this alone, but just merge it into the 'break' switch branch together. PR-URL: #26039 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to split this alone, but just merge it into the 'break'
switch branch together.
make -j4 test(UNIX), orvcbuild test(Windows) passes