[v10.x] n-api: finalize during second-pass callback #26058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
gabrielschulhof
force-pushed
the
25927-finalize-during-second-pass-callback-v10.x
branch
from
4b7d59c
to
b79bdb8
Compare
2 tasks
BethGriggs
force-pushed
the
v10.x-staging
branch
from
13f9356
to
5711238
Compare
|
Looks like this needs a rebase |
Calling into the engine from a weak callback is unsafe, however, the engine offers a way to attach a second-pass weak callback which gets called when it is safe to call into JavaScript. This moves the point at which the N-API finalize callback gets called to this latter point. Fixes: nodejs#25927 PR-URL: nodejs#25992 Backport-PR-URL: nodejs#26058 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gabrielschulhof
force-pushed
the
25927-finalize-during-second-pass-callback-v10.x
branch
from
b79bdb8
to
e66b09c
Compare
|
@mhdawson rebased. |
BethGriggs
approved these changes
Mar 12, 2019
BethGriggs
pushed a commit
that referenced
this pull request
Mar 12, 2019
Calling into the engine from a weak callback is unsafe, however, the engine offers a way to attach a second-pass weak callback which gets called when it is safe to call into JavaScript. This moves the point at which the N-API finalize callback gets called to this latter point. Fixes: #25927 PR-URL: #25992 Backport-PR-URL: #26058 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in b5588da |
gabrielschulhof
deleted the
25927-finalize-during-second-pass-callback-v10.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling into the engine from a weak callback is unsafe, however, the
engine offers a way to attach a second-pass weak callback which gets
called when it is safe to call into JavaScript. This moves the point
at which the N-API finalize callback gets called to this latter point.
Fixes: #25927
PR-URL: #25992
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes