Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: do not overwrite error when creating context #26112

Closed
wants to merge 2 commits into from
Closed

vm: do not overwrite error when creating context #26112

wants to merge 2 commits into from

Commits on Feb 14, 2019

  1. vm: do not overwrite error when creating context 

    An empty `Local<>` already indicates that an exception is pending,
so there is no need to throw an exception. In the case of Workers,
this could override a `.terminate()` call.
    @addaleax
    addaleax committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    b3ac28c View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2019

  1. fixup! vm: do not overwrite error when creating context

    @addaleax
    addaleax committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    5d74e49 View commit details
    Browse the repository at this point in the history