Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove node-report/test-api.js #26219

Merged
merged 1 commit into from
Feb 22, 2019
Merged

test: remove node-report/test-api.js #26219

merged 1 commit into from
Feb 22, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 20, 2019

There does not appear to be any difference between this test and test/node-report/test-api-nohooks.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 20, 2019
@richardlau
Copy link
Member

There does not appear to be any difference between this test and test/node-report/test-api-nohooks.js.

FTR they are slightly different in the standalone module (where the tests originate) but that difference is lost in core after the changes to the defaults (in core nothing is enabled by default but the standalone module does enable some triggers by default unless invoked via the API).

@richardlau richardlau added the report Issues and PRs related to process.report. label Feb 20, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 20, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20916/

EDIT: CI was green.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There does not appear to be any difference between this test
and test/node-report/test-api-nohooks.js.

PR-URL: nodejs#26219
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@cjihrig cjihrig merged commit 455b927 into nodejs:master Feb 22, 2019
@cjihrig cjihrig deleted the rm-test branch February 22, 2019 18:47
addaleax pushed a commit that referenced this pull request Feb 25, 2019
There does not appear to be any difference between this test
and test/node-report/test-api-nohooks.js.

PR-URL: #26219
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
There does not appear to be any difference between this test
and test/node-report/test-api-nohooks.js.

PR-URL: #26219
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. report Issues and PRs related to process.report. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants