Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: maxReservedRemoteStreams value constraints #26309

Closed
wants to merge 1 commit into from
Closed

doc: maxReservedRemoteStreams value constraints #26309

wants to merge 1 commit into from

Conversation

sebdeckers
Copy link
Contributor

Source:
https://nghttp2.org/documentation/nghttp2_option_set_max_reserved_remote_streams.html

Checklist

/cc @nodejs/http2

@nodejs-github-bot
Copy link
Collaborator

@sebdeckers sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Feb 26, 2019
@Trott
Copy link
Member

Trott commented Feb 26, 2019 •
edited
Loading

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2706/ ✅

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 26, 2019
mcollina
mcollina approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Feb 26, 2019

@sebdeckers sadly an error occured when I tried to trigger a build :(

FYI, I'm pretty sure that's just because CI is locked down right now while the upcoming security release is prepared. (Mentioning it only since @sebdeckers gave it a 😕 reaction.)

@addaleax
Copy link
Member

addaleax commented Mar 2, 2019

Landed in 2a5edaf

@addaleax addaleax closed this Mar 2, 2019
@addaleax addaleax deleted the doc-max-push-default branch March 2, 2019 13:13
addaleax pushed a commit that referenced this pull request Mar 2, 2019
@sebdeckers @addaleax
doc: maxReservedRemoteStreams value constraints
2a5edaf 
PR-URL: #26309
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 2, 2019
@sebdeckers @addaleax
doc: maxReservedRemoteStreams value constraints
3f4b27d 
PR-URL: #26309
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sebdeckers @nodejs-github-bot @Trott @addaleax @mcollina @jasnell @lpinca @cjihrig