Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,lib,test: rename node-report to report #26371

Merged
merged 2 commits into from
Mar 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions doc/api/report.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ is provided below for reference.
"/home/nodeuser/project/node/out/Release/node",
"--experimental-report",
"--diagnostic-report-uncaught-exception",
"/home/nodeuser/project/node/test/node-report/test-exception.js",
"/home/nodeuser/project/node/test/report/test-exception.js",
"child"
],
"nodejsVersion": "v12.0.0-pre",
Expand Down Expand Up @@ -66,8 +66,8 @@ is provided below for reference.
"javascriptStack": {
"message": "Error: *** test-exception.js: throwing uncaught Error",
"stack": [
"at myException (/home/nodeuser/project/node/test/node-report/test-exception.js:9:11)",
"at Object.<anonymous> (/home/nodeuser/project/node/test/node-report/test-exception.js:12:3)",
"at myException (/home/nodeuser/project/node/test/report/test-exception.js:9:11)",
"at Object.<anonymous> (/home/nodeuser/project/node/test/report/test-exception.js:12:3)",
"at Module._compile (internal/modules/cjs/loader.js:718:30)",
"at Object.Module._extensions..js (internal/modules/cjs/loader.js:729:10)",
"at Module.load (internal/modules/cjs/loader.js:617:32)",
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/bootstrap/pre_execution.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function prepareMainThreadExecution() {
// Only main thread receives signals.
setupSignalHandlers();

// Process initial configurations of node-report, if any.
// Process initial diagnostic reporting configuration, if present.
initializeReport();
initializeReportSignalHandlers(); // Main-thread-only.

Expand Down
4 changes: 2 additions & 2 deletions lib/internal/process/execution.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ function createFatalException() {
// call that threw and was never cleared. So clear it now.
clearDefaultTriggerAsyncId();

// If node-report is enabled, call into its handler to see
// If diagnostic reporting is enabled, call into its handler to see
// whether it is interested in handling the situation.
// Ignore if the error is scoped inside a domain.
// use == in the checks as we want to allow for null and undefined
Expand All @@ -119,7 +119,7 @@ function createFatalException() {
report.onUnCaughtException(er ? er.stack : undefined);
}
}
} catch {} // NOOP, node_report unavailable.
} catch {} // Ignore the exception. Diagnostic reporting is unavailable.
}

if (exceptionHandlerState.captureFn !== null) {
Expand Down
2 changes: 1 addition & 1 deletion test/common/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ function skipIfInspectorDisabled() {

function skipIfReportDisabled() {
if (!process.config.variables.node_report) {
skip('Node Report is disabled');
skip('Diagnostic reporting is disabled');
}
}

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion test/node-report/testcfg.py → test/report/testcfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
import testpy

def GetConfiguration(context, root):
return testpy.ParallelTestConfiguration(context, root, 'node-report')
return testpy.ParallelTestConfiguration(context, root, 'report')