Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,win: simplify new msbuild_arg option #26431

Closed
wants to merge 1 commit into from
Closed

build,win: simplify new msbuild_arg option #26431

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Mar 4, 2019

Make the mechanism of passing msbuild_args backwards compatible.
Refs: #25994

/CC @nodejs/build-files @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2755/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Mar 4, 2019
@refack
Copy link
Contributor Author

refack commented Mar 4, 2019 •
edited
Loading

Windows only CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/25157/
https://ci.nodejs.org/job/node-test-commit-windows-fanned/25158/

@refack refack self-assigned this Mar 4, 2019
@refack refack force-pushed the tweak-vcbuld-change branch from 1e43eb0 to 0620d5d Compare March 4, 2019 16:30
@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21220/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2019

Landed in dfffb6d 🎉

@BridgeAR BridgeAR closed this Mar 6, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 6, 2019
@refack @BridgeAR
build,win: simplify new msbuild_arg option
dfffb6d 
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack
Copy link
Contributor Author

refack commented Mar 7, 2019

@BridgeAR I appreciate the intent to help 🙏, but I self-assigned this, as per the collaborator guide.
(In this case I wanted to follow up with changes and verification in our CI setup)

@refack refack deleted the tweak-vcbuld-change branch March 7, 2019 14:37
@refack refack added landed and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 7, 2019
@refack refack removed their assignment Mar 7, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 7, 2019

@refack I was not aware of that change. It is the first time that anything like that came up for me. Isn't it possible to follow up with the changes and verification now?
I am somewhat confused by this rule.

@BridgeAR
Copy link
Member

BridgeAR commented Mar 7, 2019

I would rather have a PR marked as WIP if it should not yet land.

@refack
Copy link
Contributor Author

refack commented Mar 7, 2019

I was not aware of that change.

Understood. No harm done.

I am somewhat confused by this rule.

There was a bit of discussion around it. The idea is to allow Collaborators to indicate they wish to land their PRs on their own.

I would rather have a PR marked as WIP if it should not yet land.

The problem with that is that PRs marked with WIP do not get reviewed 🤷‍♂️

I totally understand that in a big project like node, it complicated to balance concerns like velocity, manageability, and individual preferences.

@richardlau
Copy link
Member

Maybe git-node land in node-core-utils could check if a PR is self-assigned and warn if so?

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@refack @BridgeAR
build,win: simplify new msbuild_arg option
3dd7084 
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@refack @BridgeAR
build,win: simplify new msbuild_arg option
c247153 
PR-URL: #26431
Refs: #25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@jasnell jasnell jasnell approved these changes

@joaocgreis joaocgreis joaocgreis approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@refack @nodejs-github-bot @BridgeAR @richardlau @joaocgreis @jasnell