test: rewrite ocsp test to use mustCall, etc. #26460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Mar 5, 2019
richardlau
approved these changes
Mar 5, 2019
BridgeAR
approved these changes
Mar 5, 2019
sam-github
force-pushed
the
test-ocsp-with-mustcall
branch
3 times, most recently
from
a45e5e9
to
acd99cb
Compare
BridgeAR
added
the
author ready
cjihrig
approved these changes
Mar 6, 2019
Run tests in parallel and use common.mustCall() and mustNotCall() instead of process.exit() to ensure test assertions are run.
sam-github
force-pushed
the
test-ocsp-with-mustcall
branch
from
acd99cb
to
1126aa4
Compare
|
ci: https://ci.nodejs.org/job/node-test-pull-request/21271/ Changed the commit title, using |
|
@sam-github I stopped the new CI since the last one passed. Was it intentional to start a new one? |
|
@BridgeAR I thought it passed, too, but |
|
@sam-github the reason for the complaint is that there is no LG since the last push (due to changing the commit message). It was not about the CI. |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 9, 2019
Run tests in parallel and use common.mustCall() and mustNotCall() instead of process.exit() to ensure test assertions are run. PR-URL: nodejs#26460 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 7891339 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
Run tests in parallel and use common.mustCall() and mustNotCall() instead of process.exit() to ensure test assertions are run. PR-URL: #26460 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
Run tests in parallel and use common.mustCall() and mustNotCall() instead of process.exit() to ensure test assertions are run. PR-URL: #26460 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
Run tests in parallel and use common.mustCall() and mustNotCall() instead of process.exit() to ensure test assertions are run. PR-URL: #26460 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
Run tests in parallel and use common.mustCall() and mustNotCall() instead of process.exit() to ensure test assertions are run. PR-URL: #26460 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes