Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various cpp improvement in src folder #26470

Merged
merged 1 commit into from
Mar 10, 2019
Merged

various cpp improvement in src folder #26470

merged 1 commit into from
Mar 10, 2019

Commits on Mar 10, 2019

  1. src: apply clang-tidy various improvement 

    * rewrite to default label in method ConvertUVErrorCode
* improve if condition in method PeekWritable
* remove redundant cast in node_file.cc

PR-URL: nodejs#26470
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @gengjiawen @refack
    gengjiawen authored and refack committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    6e81a95 View commit details
    Browse the repository at this point in the history