-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: de-flake test-dns-idna2008.js #26473
Conversation
Post-adding-comments custom CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5084/ |
node-daily-master failed today for the sixth day in a row due to this. Would love to fast-track this. 👍 here to fast-track. EDIT: Withdrawing pending outcome of the "use |
8e7f59c
to
7852d68
Compare
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5084/ seems like this doesn't fix the issue 🤔. Trying again https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5094/ |
So I patched the hardware. https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5099/ ✔️ |
d2e957e
to
d9607dd
Compare
LGTM! |
* use known well-behaved DNS server * force pass on ESERVFAIL PR-URL: nodejs#26473 Fixes: nodejs#25870 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
d9607dd
to
9613221
Compare
Fixes a bug I introduced in 9613221 PR-URL: nodejs#26570 Refs: nodejs#25870 Refs: nodejs#26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fixes a bug I introduced in 9613221 PR-URL: #26570 Refs: #25870 Refs: #26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fixes a bug I introduced in 9613221 PR-URL: #26570 Refs: #25870 Refs: #26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fixes a bug I introduced in 9613221 PR-URL: nodejs#26570 Refs: nodejs#25870 Refs: nodejs#26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fixes a bug I introduced in 9613221 PR-URL: #26570 Refs: #25870 Refs: #26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Use a known well behaved DNS server.
/CC @nodejs/testing
Fixes: #25870
P.S. ATM the DNS server configured on one of our CI workers, fails for the domain name used in this test:
this causes the daily CI test of master to fail: https://ci.nodejs.org/job/node-test-commit-custom-suites/
Lookup works fine when directed to use 8.8.8.8
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes