Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: assign missed deprecation code #26492

Closed
wants to merge 1 commit into from
Closed

lib: assign missed deprecation code #26492

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 7, 2019

Refs: #26245

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2798/pipeline

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Mar 7, 2019
@addaleax
Copy link
Member Author

addaleax commented Mar 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21300/

Please 👍 this comment to approve fast-tracking.

@addaleax addaleax added lib / src Issues and PRs related to general changes in the lib or src directory. fast-track PRs that do not need to wait for 48 hours to land. and removed stream Issues and PRs related to the stream subsystem. labels Mar 7, 2019
@addaleax
Copy link
Member Author

addaleax commented Mar 7, 2019

Landed in 76e67e9

@addaleax addaleax closed this Mar 7, 2019
@addaleax addaleax deleted the dep00125 branch March 7, 2019 14:49
addaleax added a commit that referenced this pull request Mar 7, 2019
@addaleax
lib: assign missed deprecation code
76e67e9 
Refs: #26245

PR-URL: #26492
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vsemozhetbyt vsemozhetbyt added the deprecations Issues and PRs related to deprecations. label Mar 7, 2019
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @nodejs-github-bot @cjihrig @richardlau @gireeshpunathil @BridgeAR @vsemozhetbyt