Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: apply clang-tidy rule modernize-use-emplace #26564

Closed
wants to merge 1 commit into from
Closed

src: apply clang-tidy rule modernize-use-emplace #26564

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-emplace.html

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 10, 2019
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21395/

addaleax
addaleax approved these changes Mar 10, 2019
View reviewed changes
src/node_messaging.cc Outdated Show resolved Hide resolved
@gengjiawen gengjiawen force-pushed the clang-tidy-emplace branch 2 times, most recently from 407cfb7 to f571048 Compare March 11, 2019 14:52
@danbev
Copy link
Contributor

danbev commented Mar 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21531/

@gengjiawen
Copy link
Member Author

gengjiawen commented Mar 21, 2019 •
edited
Loading

@danbev Can you import this and #26585, thanks.

@danbev
Copy link
Contributor

danbev commented Mar 21, 2019

Landed in f091d4e.

@danbev danbev closed this Mar 21, 2019
pull bot pushed a commit to zys-contrib/node that referenced this pull request Mar 21, 2019
@gengjiawen @danbev
src: apply clang-tidy rule modernize-use-emplace
f091d4e 
PR-URL: nodejs#26564
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targos
Copy link
Member

targos commented Mar 28, 2019

Compilation fails if this is applied on v11.x-staging:

make -C out BUILDTYPE=Release V=
  TOUCH cbca18b98112d8bc68a52ca94d8199523305cf11.intermediate
  ACTION _home_mzasso_git_nodejs_v11_x_deps_v8_gypfiles_v8_gyp_v8_torque_host_run_torque cbca18b98112d8bc68a52ca94d8199523305cf11.intermediate
  TOUCH b4eb7431cd5126f82ef689c4118ba80414d6aa1b.intermediate
  ACTION Generating inspector protocol sources from protocol json b4eb7431cd5126f82ef689c4118ba80414d6aa1b.intermediate
  TOUCH 3c3044250b6b8174e7fa6ce999544ccc88deb4fe.intermediate
  ACTION Generating node protocol sources from protocol json 3c3044250b6b8174e7fa6ce999544ccc88deb4fe.intermediate
  CXX(target) /home/mzasso/git/nodejs/v11.x/out/Release/obj.target/node_lib/src/inspector_socket.o
../src/inspector_socket.cc: In static member function ‘static int node::inspector::{anonymous}::HttpHandler::OnMessageComplete(parser_t*)’:
../src/inspector_socket.cc:570:43: error: cannot bind bitfield ‘parser->http_parser::upgrade’ to ‘unsigned int&’
                                   parser->upgrade,
                                   ~~~~~~~~^~~~~~~
make[1]: *** [node_lib.target.mk:340: /home/mzasso/git/nodejs/v11.x/out/Release/obj.target/node_lib/src/inspector_socket.o] Error 1

Please open a backport PR or apply the dont-land-on label.

This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gengjiawen @BridgeAR @danbev @targos @bnoordhuis @addaleax @joyeecheung @nodejs-github-bot