-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change 2018 to 2019 for 10.15.3 entry #26584
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Mar 11, 2019
vsemozhetbyt
approved these changes
Mar 11, 2019
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 11, 2019
BethGriggs
approved these changes
Mar 11, 2019
BridgeAR
approved these changes
Mar 11, 2019
vsemozhetbyt
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Mar 11, 2019
vsemozhetbyt
pushed a commit
that referenced
this pull request
Mar 11, 2019
Most minor, 2018 should be 2019 for 10.15.3 PR-URL: #26584 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Landed in 06879aa |
This does not land cleanly on v11. It seems like no v10 changelog has landed on v11 since v10.12.0? @nodejs/releasers to me this seems like a mistake? |
No, this is normal. We don't backport release commits |
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most minor of changes, a typo in the Changelog!
This is the first time I've looked at the node changelog and, because of the typo, I thought I was in the wrong place. Hope this helps!
Checklist