Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: set the trace category update handler during bootstrap #26605

Closed
wants to merge 2 commits into from
Closed

process: set the trace category update handler during bootstrap #26605

wants to merge 2 commits into from

Commits on Mar 18, 2019

  1. test: refactor trace event category tests 

    - Add descriptions
- Filter out the relevant traces for testing, ignore the irrelevant
  ones.
    @joyeecheung
    joyeecheung committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    d47eede View commit details
    Browse the repository at this point in the history

  2. process: set the trace category update handler during bootstrap 

    Set the trace category update handler during bootstrap, but delay
the initial invocation of it until pre-execution. In addition, do
not serialize the `node.async_hooks` category state when loading
the trace_event binding during bootstrap, since it depends on
run time states (e.g. CLI flags). Instead, use the
`isTraceCategoryEnabled` v8 intrinsics to query that value during
pre-execution.
    @joyeecheung
    joyeecheung committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    f0c72c5 View commit details
    Browse the repository at this point in the history