Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "crypto: add KeyObject.asymmetricKeySize" #26636

Closed
wants to merge 1 commit into from
Closed

Revert "crypto: add KeyObject.asymmetricKeySize" #26636

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

This reverts commit 4895927 (#26387). While a similar API would be useful, I think the API should not have landed as it is, see #26631 and #26631 (comment).

Fixes: #26631

cc @nodejs/crypto

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 13, 2019
@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2893/pipeline

@BridgeAR
Copy link
Member

@tniessen I just saw this. I'll back out the PR from the next release and add do not land tags until this is resolved.

@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
ryzokuken
ryzokuken approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as the said method sets false expectations as discussed in the issue.

@tniessen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/21562/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 15, 2019
@tniessen
Copy link
Member Author

Landed in 6f77af5.

@tniessen tniessen closed this Mar 15, 2019
tniessen added a commit that referenced this pull request Mar 15, 2019
@tniessen
Revert "crypto: add KeyObject.asymmetricKeySize"
6f77af5 
This reverts commit 4895927.

PR-URL: #26636
Fixes: #26631
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@Trott Trott Trott approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keyObject.asymmetricKeySize returns incorrect values for EC and Ed keys
6 participants
@tniessen @nodejs-github-bot @BridgeAR @bnoordhuis @Trott @ryzokuken