Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x backport] process: move more dependency of environment variables to pre-execution #26662

Closed
wants to merge 4 commits into from
Closed

[v11.x backport] process: move more dependency of environment variables to pre-execution #26662

wants to merge 4 commits into from

Commits on Mar 17, 2019

  1. process: call prepareMainThreadExecution in node inspect 

    Since we should treat the node-inspect as third-party
user code.

PR-URL: nodejs#26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @joyeecheung @refack
    joyeecheung authored and refack committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    4be5076 View commit details
    Browse the repository at this point in the history

  2. process: set up process warning handler in pre-execution 

    Since it depends on environment variables.

PR-URL: nodejs#26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @joyeecheung @refack
    joyeecheung authored and refack committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    7ab1a11 View commit details
    Browse the repository at this point in the history

  3. process: handle process.env.NODE_V8_COVERAGE in pre-execution 

    Since this depends on environment variable, and the worker threads
do not need to persist the variable value because they cannot
switch cwd.

PR-URL: nodejs#26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @joyeecheung @refack
    joyeecheung authored and refack committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    00e7dd2 View commit details
    Browse the repository at this point in the history

  4. process: move deprecation warning setup for --debug* args

    @refack
    refack committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    f442b54 View commit details
    Browse the repository at this point in the history