-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build,deps,v8: loose ends #26666
build,deps,v8: loose ends #26666
Conversation
CI: https://ci.nodejs.org/job/node-test-pull-request/21550/ |
Micro-nit: Commit message first word should be an imperative verb, so maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Much needed.
PR-URL: nodejs#26666 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Some loose ends for #25852
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes