fix changelog date typo (v6.17.0) #26831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well actually since the ideal time to figure out the prefix is before making the commit, wouldn't just looking at the modified paths with |
vsemozhetbyt
approved these changes
Mar 21, 2019
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
lpinca
approved these changes
Mar 21, 2019
BethGriggs
approved these changes
Mar 21, 2019
ssethu24
approved these changes
Mar 21, 2019
vsemozhetbyt
added
fast-track
|
Landed in 0622ce6 |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Mar 21, 2019
PR-URL: #26831 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
|
Thanks @vsemozhetbyt and everyone. Would be interested to understand what the changelog advice about identifying subsystems for commit messages is getting at if someone has a chance to comment. |
|
@jmm If nobody answers here, please, create an issue with the question) |
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same typo is also at the top of https://nodejs.org/en/blog/vulnerability/february-2019-security-releases/.
On a side note, I must be misunderstanding something because I'm not seeing how the contributing advice for identifying subsystems touched when writing a commit message would help:
That output doesn't seem to help identify changed files / it's actually saying to list changed files as input to the command. I feel like the intention here would be to do something more like?:
But even so not sure how helpful that is in identifying the expected prefix. E.g. the examples given are
src, which I assume refers to the top-levelsrc/directory, andnet, which I assume refers tolib/net.js.