Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: v8 build on FreeBSD 10.2 (v8 4.5 upgrade) #2692

Closed
wants to merge 1 commit into from

Commits on Sep 4, 2015

  1. deps: backport 75e43a6 from v8 upstream (again)

    Note: When this was cherry-picked for v8 v4.4 (landed in nodejs#2636),
    test-heap.cc:1989 chunk did not exist. It now exists in
    v8 v4.5.101.30. This PR completes the cherry pick of the whole commit
    from v8.
    
    Original commit message:
      Use static_cast<> for NULL (clang 3.7)
    
      The following errors come up when compiling v8
       with clang 3.7 on FreeBSD/amd64:
    
      src/runtime/runtime-i18n.cc:629:37: error: reinterpret_cast from
      'nullptr_t' to 'v8::internal::Smi *' is not allowed
        local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL));
                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
      test/cctest/test-heap.cc:131:20: error: reinterpret_cast from
            'nullptr_t' to 'v8::internal::Object *' is not allowed
        Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate);
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      test/cctest/test-heap.cc:1989:18: error: reinterpret_cast from
            'nullptr_t' to 'Address' (aka 'unsigned char *') is not
            allowed
        Address base = reinterpret_cast<Address>(NULL);
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
      +add myself to the AUTHORS file.
    
      BUG=
    
      Review URL: https://codereview.chromium.org/1277353002
    
      Cr-Commit-Position: refs/heads/master@{nodejs#30103}
    saper authored and sambthompson committed Sep 4, 2015
    Configuration menu
    Copy the full SHA
    2a524fa View commit details
    Browse the repository at this point in the history