Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt #26935

Closed
wants to merge 1 commit into from
Closed

src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt #26935

wants to merge 1 commit into from

Commits on Mar 26, 2019

  1. src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt 

    If Debugger.setAsyncCallStackDepth is sent during bootstrap,
we cannot immediately call into JS to enable the hooks, which could
interrupt the JS execution of bootstrap. So instead we save the
notification in the inspector agent if it's sent in the middle of
bootstrap, and process the notification later here.

Refs: nodejs#26798
    @joyeecheung
    joyeecheung committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    d5f9395 View commit details
    Browse the repository at this point in the history