Revert "console: use consolePropAttributes for k-bind properties in c… #26943
Conversation
…onstructor" This reverts commit ed5e69d.
nodejs-github-bot
added
the
console
|
The failed test case it flaky and Travis is only an indicator about things working or not. I don't think that this should be reverted / that it's related. |
|
+1 to fast track |
|
@BridgeAR Ah good to know that it's flakey, thanks! I'm a little confused about this issue as it does seem to be consistent on master when I run it locally and after reverting it did not fail (though I did not run it more than twice). |
|
The nightly Ref to flake investigation: #26401 |
|
We can find out by reverting it and see if it flakes again. If it flakes, revert the revert. |
|
To get the test at least pass again on most systems, it's probably fine to revert it for now. It just does not seem to be the actual issue to me. |
@gireeshpunathil was asking for a core dump in #26401, if anyone could accommodate... tl;dr I'm +1 on reverting to get |
|
Landed in a8eac78. |
…onstructor" This reverts commit ed5e69d. PR-URL: #26943 Refs: #26850 (comment) Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
This did not fix the issue as described here: #26401 (comment) This revert should probably be reverted again. |
This is a reland of nodejs#26850. It was speculatively reverted but it turned out that this did not cause any trouble. PR-URL: nodejs#27352 Refs: nodejs#26943 Refs: nodejs#26850 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This is a reland of #26850. It was speculatively reverted but it turned out that this did not cause any trouble. PR-URL: #27352 Refs: #26943 Refs: #26850 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
…onstructor"
This reverts commit ed5e69d.
Refs: #26850 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes