Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esm: use primordials #26954

Closed
wants to merge 1 commit into from
Closed

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Mar 28, 2019

Converted uses of Object and Map to use frozen built
in primordials.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes

Converted uses of Object and Map to use frozen built
in primordials.
@MylesBorins
Copy link
Contributor Author

Can we fastrack please?

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2019
@targos
Copy link
Member

targos commented Mar 30, 2019

Landed in 7a54709

@targos targos closed this Mar 30, 2019
targos pushed a commit that referenced this pull request Mar 30, 2019
Converted uses of Object and Map to use frozen built
in primordials.

PR-URL: #26954
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
Converted uses of Object and Map to use frozen built
in primordials.

PR-URL: #26954
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants