http2: window size connection control #26962
Conversation
Allow to control the connection window size by setting local window size (local endpoints's window size) to the given window_size. To increase window size, this function may submit WINDOW_UPDATE frame to transmission queue. Pay attention, this function takes the absolute value of window size to set, rather than the delta, the delta is computed by the update operation.
nodejs-github-bot
added
c++
|
@nodejs/http2 PTAL |
| @@ -2222,6 +2249,7 @@ added: v8.4.0 | |||
| | `0x0b` | Enhance Your Calm | `http2.constants.NGHTTP2_ENHANCE_YOUR_CALM` | | |||
| | `0x0c` | Inadequate Security | `http2.constants.NGHTTP2_INADEQUATE_SECURITY` | | |||
| | `0x0d` | HTTP/1.1 Required | `http2.constants.NGHTTP2_HTTP_1_1_REQUIRED` | | |||
| | `0x0d` | HTTP/1.1 Required | `http2.constants.NGHTTP2_HTTP_1_1_REQUIRED` | | |||
| than the delta. | ||
|
|
||
| ```js | ||
| clientSession.on('connect', (session) => sendSettings(session, (s) => cb(s))); |
There was a problem hiding this comment.
Perhaps (s) => cb(s) would be more clear, as documentation, if it were written with meaningful variable names (settings?). No need to squeeze it on 80ch; just go multi-line.
doc/api/http2.md
Outdated
| --> | ||
|
|
||
| * `windowSize` {number} | ||
| * Returns: 0 |
There was a problem hiding this comment.
In fact it's not exaclty the case, at this stage it returns only zero or throws ERR_OUT_OF_RANGE, the function is mapped to nghttp2_session_set_local_window_size.
If the library changes its internal, the value will be returned.
If it does not fit the philosophy of node, we can return a generic errror that maps all errors at the native code level.
| @@ -524,6 +524,33 @@ Used to set a callback function that is called when there is no activity on | |||
| the `Http2Session` after `msecs` milliseconds. The given `callback` is | |||
| registered as a listener on the `'timeout'` event. | |||
|
|
|||
| #### http2session.setConnectionWindowSize(windowSize) | |||
There was a problem hiding this comment.
Would a getter and setter be better for an API?
There was a problem hiding this comment.
It's a good point, I am not sure to be able to detect it. There is not acknoledge on a SETTINGS_INITIAL_WINDOW_SIZE
But, we can add a test for testing the limit of the buffer allocation for instance and insure that code results are covered.
|
Ping @migounette , can you rebase and add some tests so that we can move forward ? |
|
Back on tracks for this activity, I will adresse it as soon as possible |
|
@migounette, this needs a rebase. |
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff
to
2935f72
Compare
|
Unfortunately this work appears to have stalled out. Closing but can reopen if it is picked back up again and rebased. |
PR-URL: nodejs#35978 Fixes: nodejs#31084 Refs: nodejs#26962 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Allow to control the connection window size by setting local window
size (local endpoints's window size) to the given window_size.
To increase window size, this function may submit WINDOW_UPDATE frame
to transmission queue.
Pay attention, this function takes the absolute value of window size to set,
rather than the delta, the delta is computed by the update operation.