Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix inspector dependency resolution #27026

Closed
wants to merge 1 commit into from

Commits on Mar 31, 2019

  1. build: fix inspector dependency resolution

    It was reported that parallel builds on Windows sometimes error because
    of missing intermediate files.
    
    On closer inspection I noticed that some files are copied from src/ to
    the intermediate build directory in a way where they don't participate
    in dependency resolution. Put another way, the build system doesn't
    know to wait for the copy to complete because we don't tell it to.
    
    Fix that by not copying around files but instead making the script that
    processes them a little smarter about where to find them and where to
    store the results.
    
    Fixes: nodejs#27025
    bnoordhuis committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    de0ea90 View commit details
    Browse the repository at this point in the history